[cmake-developers] Some trivial patches
Tobias Hunger
Tobias.Hunger at qt.io
Thu Jun 2 05:15:27 EDT 2016
On Mi, 2016-06-01 at 11:18 -0400, Brad King wrote:
> On 06/01/2016 05:04 AM, Tobias Hunger wrote:
> > Attached you will find a couple of really small changes that add const to a
> > method and fix a couple of typos in comments. Trivial stuff.
>
> Thanks. I've applied the changes:
>
> cmSearchPath: Fix typo in comment
> https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=814e774e
>
> cmSourceFileLocation: Fix typo in comment
> https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bd4fef64
>
> cmGlobalGenerator: Make IsMultiConfig() const
> https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2175e5bf
>
> > This is mostly to figure out how to contribute code:-)
>
> Good job. For large changes (e.g. cmake-daemon work) feel free
> to publish your branch somewhere and post a link here. For most
> changes please post here.
Why did the typo fixes end up in the master branch and the const fix in the next
branch?
Do I need to do something to get it from next to master at some point?
Best Regards,
Tobias
--
Tobias Hunger, Senior Software Engineer | The Qt Company
The Qt Company GmbH, Rudower Chaussee 13, D-12489 Berlin
Geschäftsführer: Mika Pälsi, Juha Varelius, Mika Harjuaho. Sitz der
Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 144331 B
More information about the cmake-developers
mailing list