[cmake-developers] Some trivial patches

Daniel Pfeifer daniel at pfeifer-mail.de
Thu Jun 2 06:54:42 EDT 2016


On Thu, Jun 2, 2016 at 11:15 AM, Tobias Hunger <Tobias.Hunger at qt.io> wrote:
> On Mi, 2016-06-01 at 11:18 -0400, Brad King wrote:
>> On 06/01/2016 05:04 AM, Tobias Hunger wrote:
>> > Attached you will find a couple of really small changes that add const to a
>> > method and fix a couple of typos in comments. Trivial stuff.
>>
>> Thanks.  I've applied the changes:
>>
>>  cmSearchPath: Fix typo in comment
>>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=814e774e
>>
>>  cmSourceFileLocation: Fix typo in comment
>>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bd4fef64
>>
>>  cmGlobalGenerator: Make IsMultiConfig() const
>>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2175e5bf
>>
>> > This is mostly to figure out how to contribute code:-)
>>
>> Good job.  For large changes (e.g. cmake-daemon work) feel free
>> to publish your branch somewhere and post a link here.  For most
>> changes please post here.
>
> Why did the typo fixes end up in the master branch and the const fix in the next
> branch?

Because of the code freeze for CMake 3.6:
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/16479

> Do I need to do something to get it from next to master at some point?

No.


More information about the cmake-developers mailing list