[cmake-developers] use-generator-target topic regressed buildsystem properties

[Stephen Kelly]

Brad King wrote:

> Steve,
> 
> The topic merged here:
> 
>  Merge topic 'use-generator-target'
>  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6e5953e9
> 
> regressed handling of the buildsystem-aware properties.
> I fixed some of the problems and added test cases.  

Thanks for those!

> However, additional problems remain.  I've attached updates
> to the test suite that demonstrate the failures.  The problem
> is distinguishing an appended empty value from the empty
> sentinel values used in cmState.
> 
> As shown by the USER_PROP test cases added above and in the
> attached patch, the behavior for non-buildsystem properties
> is to never append empty values.  That was changed at some
> point in the past for buildsystem property values when we
> started recording internal data structures to store them.

Yes, that is likely a bug introduced in the last few years. Those should 
behave the same.

> One possible fix to the problems is to avoid allowing empty
> values to be appended at all as is done for non-buildsystem
> properties.  

I'm sure that's possible. Is it acceptable to fix it?

Another possible fix is to store a vector of sentinal positions for each 
buildsystem property.

I can do either over the next few days.

Thanks,

Steve.