[cmake-developers] [CPack] [CPackRPM] mantis ticket 13176 CPackRPM support for per-component summary and description

[Eric Noulard]

2014-10-14 9:03 GMT+02:00 Domen Vrankar <domen.vrankar at gmail.com>:

> Sorry for spamming...
>
> I noticed that the previous patch would break user provided rpm spec files
> so I'm attaching a new patch that fixes that problem with a bit more
> variable juggling.
>


Hi Domen,

I did re-assign the bug entry to you
http://public.kitware.com/Bug/view.php?id=13176

Then we discussing various patches I suggest you to attach the patch
directly to the tracker
that way it's easy to see the patch history and if ever some patch version
is obsolete you may simply remove it from the tracker.


>
> I also have a question. Would CPack also need something like
> CPACK_COMPONENT_<component>_PACKAGE_SUMMARY that could be used by
> CPACK_RPM_<component>_PACKAGE_SUMMARY as default value?
>


Not sure of that one.
We already have "CPACK_COMPONENT_GROUP_CMAKE_DESCRIPTION"
which may be a default value for "CPACK_RPM_<component>_PACKAGE_
SUMMARY" if packaging is done "by compoent group" (which is the default):

The behavior of the various CPack generator w.r.t. mono- or multi-
file/package generation vary,
see:
http://www.cmake.org/Wiki/CMake:Component_Install_With_CPack#CPack_Generator_specific_behavior

e.g. for NSIS or PackageMaker I don't know what you can do with
"CPACK_COMPONENT_<component>_
PACKAGE_SUMMARY" because there is only one package.

Otherwise I only read the patch and it looks good.

However you should at least:
  1) run ctest -R CPack  --> this the "minimal" way to run CPack related
tests in the CMake tree
  2) enhance or provide a specific test for the new behavior.


 Eric

>
> Thanks,
> Domen
>
>
> 2014-10-14 0:23 GMT+02:00 Domen Vrankar <domen.vrankar at gmail.com>:
>
>> Message was sent to early by accident so I'm resending the rest.
>>
>> 2014-10-14 0:17 GMT+02:00 Domen Vrankar <domen.vrankar at gmail.com>:
>>
>>> Hi,
>>>
>>> I extended the proposed patch for ticket 13176 with:
>>> - documentation section
>>> - CPACK_RPM_<component>_PACKAGE_DESCRIPTION fallback to
>>> CPACK_COMPONENT_<compName>_DESCRIPTION
>>> - handling of cases when one component sets its variable and the other
>>> doesn't
>>>
>>
>> e.g.
>> #set(CPACK_RPM_test_PACKAGE_SUMMARY "test_summary")
>> set(CPACK_RPM_bin_PACKAGE_SUMMARY "bin_summary")
>>
>> Could somebody please review the patch attached to this mail?
>>
>>
>>>
>>> Regards,
>>> Domen
>>>
>>
>>
>
> --
>
> Powered by www.kitware.com
>
> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/CMake_FAQ
>
> Kitware offers various services to support the CMake community. For more
> information on each offering, please visit:
>
> CMake Support: http://cmake.org/cmake/help/support.html
> CMake Consulting: http://cmake.org/cmake/help/consulting.html
> CMake Training Courses: http://cmake.org/cmake/help/training.html
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/cmake-developers
>



-- 
Erk
L'élection n'est pas la démocratie -- http://www.le-message.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141014/d9e23c4e/attachment-0002.html>