[cmake-developers] [CPack] [CPackRPM] mantis ticket 13176 CPackRPM support for per-component summary and description

[Domen Vrankar]

2014-10-14 9:28 GMT+02:00 Eric Noulard <eric.noulard at gmail.com>:

>
>
> 2014-10-14 9:03 GMT+02:00 Domen Vrankar <domen.vrankar at gmail.com>:
>
>> Sorry for spamming...
>>
>> I noticed that the previous patch would break user provided rpm spec
>> files so I'm attaching a new patch that fixes that problem with a bit more
>> variable juggling.
>>
>
>
> Hi Domen,
>
> I did re-assign the bug entry to you
> http://public.kitware.com/Bug/view.php?id=13176
>

Noticed that. Thanks. I did not notice that I can reassign bugs myself.


>
> Then we discussing various patches I suggest you to attach the patch
> directly to the tracker
> that way it's easy to see the patch history and if ever some patch version
> is obsolete you may simply remove it from the tracker.
>
>

Done.


>
>> I also have a question. Would CPack also need something like
>> CPACK_COMPONENT_<component>_PACKAGE_SUMMARY that could be used by
>> CPACK_RPM_<component>_PACKAGE_SUMMARY as default value?
>>
>
>
> Not sure of that one.
> We already have "CPACK_COMPONENT_GROUP_CMAKE_DESCRIPTION"
> which may be a default value for "CPACK_RPM_<component>_PACKAGE_
> SUMMARY" if packaging is done "by compoent group" (which is the default):
>
> The behavior of the various CPack generator w.r.t. mono- or multi-
> file/package generation vary,
> see:
>
> http://www.cmake.org/Wiki/CMake:Component_Install_With_CPack#CPack_Generator_specific_behavior
>
>
I'll read it in the afternoon.


> e.g. for NSIS or PackageMaker I don't know what you can do with
> "CPACK_COMPONENT_<component>_
> PACKAGE_SUMMARY" because there is only one package.
>
> Otherwise I only read the patch and it looks good.
>

> However you should at least:
>   1) run ctest -R CPack  --> this the "minimal" way to run CPack related
> tests in the CMake tree
>

Forgot to run the tests the first time but remembered afterwards.


>   2) enhance or provide a specific test for the new behavior.
>
>
Will do this in the afternoon.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141014/e1fd870f/attachment-0002.html>