[cmake-developers] FindThreads_overhaul topic
Rolf Eike Beer
eike at sf-mail.de
Wed Oct 8 11:48:13 EDT 2014
Am Mittwoch, 8. Oktober 2014, 11:44:28 schrieb Brad King:
> On 10/08/2014 11:37 AM, Rolf Eike Beer wrote:
> > All credits go to Timo Rothenpieler
>
> Okay. Please add a "Co-Author: " or "Inspired-by: " footer line to give
> this credit.
He is recorded as author of that change. Only the first and last of the 3
commits in that branch are authored by me, and recorded that way.
> > I'm not sure about Threads::Interface, it sounds so "generic" or
> > "abstract" to me, but this target offers no abstraction of the thread
> > API. All others have different up- and downsides, so I think I'll stay
> > with Threads::Threads, that is the one that probably results in the least
> > blame for a badly chosen name.
> On second thought I agree Threads::Interface is too generic. It exposes
> an implementation detail in the name. I agree Threads::Threads is the
> best or now. I suspect other packages will encounter a similar double-name
> later.
Will push an update soonish.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141008/82165980/attachment-0002.sig>
More information about the cmake-developers
mailing list