[cmake-developers] FindThreads_overhaul topic
Robert Maynard
robert.maynard at kitware.com
Wed Oct 8 14:50:03 EDT 2014
As an aside have we formally documented that we are reserving the
CMake namespace on imported targets anywhere?
On Wed, Oct 8, 2014 at 11:48 AM, Rolf Eike Beer <eike at sf-mail.de> wrote:
> Am Mittwoch, 8. Oktober 2014, 11:44:28 schrieb Brad King:
>> On 10/08/2014 11:37 AM, Rolf Eike Beer wrote:
>> > All credits go to Timo Rothenpieler
>>
>> Okay. Please add a "Co-Author: " or "Inspired-by: " footer line to give
>> this credit.
>
> He is recorded as author of that change. Only the first and last of the 3
> commits in that branch are authored by me, and recorded that way.
>
>> > I'm not sure about Threads::Interface, it sounds so "generic" or
>> > "abstract" to me, but this target offers no abstraction of the thread
>> > API. All others have different up- and downsides, so I think I'll stay
>> > with Threads::Threads, that is the one that probably results in the least
>> > blame for a badly chosen name.
>> On second thought I agree Threads::Interface is too generic. It exposes
>> an implementation detail in the name. I agree Threads::Threads is the
>> best or now. I suspect other packages will encounter a similar double-name
>> later.
>
> Will push an update soonish.
> --
>
> Powered by www.kitware.com
>
> Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
>
> Kitware offers various services to support the CMake community. For more information on each offering, please visit:
>
> CMake Support: http://cmake.org/cmake/help/support.html
> CMake Consulting: http://cmake.org/cmake/help/consulting.html
> CMake Training Courses: http://cmake.org/cmake/help/training.html
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/cmake-developers
More information about the cmake-developers
mailing list