[cmake-developers] Review Request for ExternalProjects: Only update certain git submodules

[Gereon Kremer]

Hi,

Attached is a patch for the ExternalProject test that simply passes an 
empty list.
I'd like to pass further testing, i.e. checking against a submodule 
being another local git, to someone who is more familiar with this 
testing setup...

We have an external project with many submodules (-> boost...) and 
confirm that only the submodules given in the option are cloned and updated.
However I guess, you want a confirmation from somebody else... :-)

Cheers,
Gereon

On 01/09/2014 08:31 PM, David Cole wrote:
> This looks like a reasonable patch to me (just by eye, have not tried 
> it personally). *Although* it would be even better if there were an 
> additional case added in the ExternalProject test that handles passing 
> in (1) an empty git submodule list, and (2) a valid list. Although, 
> unless you add code to the setup of the test git repo for that test, 
> it won't have any submodules in it. And we don't want to introduce any 
> network dependencies to the test suite, so no referencing a real live 
> git repo on the internet.
>
> I'd like to see a follow up patch to this one that adds *some* 
> testing, too, even if just of the empty list smoke test variety...
>
> Does anybody listening here have a project with some git submodules, 
> and some time to give this a test drive? If so, please do, and let us 
> know the results. If they're positive, we could take the follow up to 
> this patch and get it into CMake 'next'.
>
>
> Thanks,
> David C.
>

-- 
Gereon Kremer
Lehr- und Forschungsgebiet Theorie Hybrider Systeme
RWTH Aachen
Tel: +49 241 80 21242

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Added-a-simple-testcase-for-GIT_SUBMODULES-option-pa.patch
Type: text/x-patch
Size: 1206 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140110/61e1d2e6/attachment-0001.bin>