[cmake-developers] [New Module] FindOpenCL, FindHg
Rolf Eike Beer
eike at sf-mail.de
Sun Feb 16 14:10:49 EST 2014
Am Sonntag, 16. Februar 2014, 18:43:01 schrieb Matthäus G. Chajdas:
> Hi Eike,
>
> thanks for reviewing! I've just pushed a new version, which should fix
> all the issues you mentioned. I'm also setting now Hg_FOUND using
> FOUND_VAR (this is also recommended in the documentation.)
>
> Anything more left to do? The only thing which bothers me is the
> _VERSION_STRING in FindHg (which is similar to FindGit) and the same
> variable being called _VERSION in OpenCL, if there is a policy on that,
> I would like to use the same variable name in both. Right now I was
> aiming more for consistency with existing packages.
There has been a Modules/readme.txt, no idea where it is now in rst. But the
preferred nameing ins Hg_VERSION_STRING and OpenCL_VERSION_STRING.
Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140216/5f34e80d/attachment-0002.sig>
More information about the cmake-developers
mailing list