[cmake-developers] [New Module] FindOpenCL, FindHg

"Matthäus G. Chajdas" cmake at anteru.net
Sun Feb 16 14:26:22 EST 2014


Hi,

couldn't find it in the documentation either :(

I've changed it to OPENCL_VERSION_STRING. Should I apply for commit
access now?

Cheers,
  Matthäus

On 16.02.2014 20:10, Rolf Eike Beer wrote:
> Am Sonntag, 16. Februar 2014, 18:43:01 schrieb Matthäus G. Chajdas:
>> Hi Eike,
>>
>> thanks for reviewing! I've just pushed a new version, which should fix
>> all the issues you mentioned. I'm also setting now Hg_FOUND using
>> FOUND_VAR (this is also recommended in the documentation.)
>>
>> Anything more left to do? The only thing which bothers me is the
>> _VERSION_STRING in FindHg (which is similar to FindGit) and the same
>> variable being called _VERSION in OpenCL, if there is a policy on that,
>> I would like to use the same variable name in both. Right now I was
>> aiming more for consistency with existing packages.
> 
> There has been a Modules/readme.txt, no idea where it is now in rst. But the 
> preferred nameing ins Hg_VERSION_STRING and OpenCL_VERSION_STRING.
> 
> Eike
> 
> 
> 




More information about the cmake-developers mailing list