[cmake-developers] Perforce patch for CTest

[Pedro Navarro]

Attached is a new patch with Rolf's suggestions (improved regex and usage
of size_type to go through the Options vector). I just amended my commit
and created a new patch file, instead of doing two smaller ones.

Pedro


On Wed, Oct 2, 2013 at 2:28 PM, Pedro Navarro <pnavarro at netflix.com> wrote:

> The issue with the P4LANGUAGE environment variable, as well as the -L
> switch is that I don't know the language string I need to set it to.
> Another thing is that Perforce says that it will change the text of the
> error messages, so it's not clear if the ouput I'm parsing will be affected
> or not. I guess we would need to set up a temporary P4 server and test all
> of this but, for now, we offer enough flexibility to let users set the
> language if they have a non-English Perforce.
>
> Pedro
>
>
> On Wed, Oct 2, 2013 at 1:19 PM, Rolf Eike Beer <eike at sf-mail.de> wrote:
>
>> Am Mittwoch, 2. Oktober 2013, 13:10:20 schrieb Pedro Navarro:
>> > > >    - It requires an English version of Perforce (use the P4_OPTIONS
>> > > >    variable, documented below to pass the -L switch to change the
>> > > >    message
>> > > >    language if you installation has a different one). It shouldn't
>> be
>> > > >    too
>> > > >
>> > > > hard to change the regular expressions used for parsing to not key
>> on a
>> > > > specific word but on character ranges. I'll look into that if this
>> > >
>> > > becomes
>> > >
>> > > > an issue.
>> > >
>> > > Maybe set P4_OPTIONS automatically to -Lenglish (or whatever) in case
>> it
>> > > is
>> > > not set?
>> >
>> > I tried that originally but had no effect. Also, on the perforce
>> > documentation it says that "Specifies the language to use for error
>> > messages from the Perforce service. In order for this flag to work, your
>> > administrator must have loaded support for non-English messages in the
>> > database", so I didn't feel comfortable adding a flag globably without
>> > knowing it might even trigger an error (like invalid language or
>> something
>> > like that).
>> >
>> > Perforce offers the P4LANGUAGE environment variable which can be used to
>> > configure the client for updates, and we also have the P4_OPTIONS
>> variable,
>> > so I think for now it's a good solution/workaround until we have more
>> > information.
>>
>> Can you set P4LANGUANGE unconditionally then? Like it is done in
>> FindSubversion.cmake to get proper output.
>>
>> And of course this needs testcases, and a host that has Perforce
>> installed and
>> drives those tests. ;)
>>
>> Eike
>> --
>>
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Please keep messages on-topic and check the CMake FAQ at:
>> http://www.cmake.org/Wiki/CMake_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20131002/83baf781/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Added-support-for-Perforce.patch
Type: application/octet-stream
Size: 22302 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20131002/83baf781/attachment-0002.obj>