[cmake-developers] string(MAKE_C_IDENTIFIER) subcommand

[Rolf Eike Beer]

Stephen Kelly wrote:
> Hi there,
> 
> GenerateExportHeader has a bug where if the target name is kde-config, for
> example, it generates content like
> 
> #ifndef KDE-CONFIG_EXPORT_H
> #define KDE-CONFIG_EXPORT_H
> 
> This is not as intended. The problem is that the target name is used with
> TOUPPER, but is not otherwise filtered for invalid characters.
> 
> I propose adding a string subcommand MAKE_C_IDENTIFIER and using it.
> 
> Any comments?

Shouldn't that be named MAKE_C_INDENTIFIER? :P

SCNR,

Eike
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20121222/ce91b397/attachment.sig>