[cmake-developers] string(MAKE_C_IDENTIFIER) subcommand

Stephen Kelly steveire at gmail.com
Sat Dec 22 07:02:54 EST 2012


Hi there,

GenerateExportHeader has a bug where if the target name is kde-config, for 
example, it generates content like 

#ifndef KDE-CONFIG_EXPORT_H
#define KDE-CONFIG_EXPORT_H

This is not as intended. The problem is that the target name is used with 
TOUPPER, but is not otherwise filtered for invalid characters.

I propose adding a string subcommand MAKE_C_IDENTIFIER and using it. 

Any comments?

Thanks,

Steve.






More information about the cmake-developers mailing list