[cmake-developers] string(MAKE_C_IDENTIFIER) subcommand

[Mathias Gaunard]

On 22/12/12 13:02, Stephen Kelly wrote:
>
> Hi there,
>
> GenerateExportHeader has a bug where if the target name is kde-config, for
> example, it generates content like
>
> #ifndef KDE-CONFIG_EXPORT_H
> #define KDE-CONFIG_EXPORT_H
>
> This is not as intended. The problem is that the target name is used with
> TOUPPER, but is not otherwise filtered for invalid characters.
>
> I propose adding a string subcommand MAKE_C_IDENTIFIER and using it.
>
> Any comments?

Why does it need to be built-in?
Do it as a cmake macro or function.