[cmake-developers] GenerateExportHeader macro in CMake?
david.cole at kitware.com
Wed Aug 24 14:49:39 EDT 2011
On Wed, Aug 24, 2011 at 2:27 PM, Stephen Kelly <steveire at gmail.com> wrote:
> David Cole wrote:
>> The test itself passes on AIX, as seen here:
>> It's only the particular machine that you pointed to that has
>> problems. There are *several* tests that fail on that machine with the
>> space in the path. That's one of the reasons it's only in "Nightly"
>> and not "Nightly Expected"
> Ok. Nevertheless I think it would make sense for cdash to always check out
> and build in a directory with a space in it. There could be other bugs
The vast majority of our dashboard builds are done on build trees and
source trees that have a space in the full path name. We only do
non-space-in-the-path builds on machines where there are problems with
other tools over which we have no control.
We all strive to have cmake, ctest and cpack work flawlessly when
there are spaces in file and path names. We only punt on a given
dashboard machine when we have to.
>>>> That only leaves Watcom as you say, and I've just tried to simplify the
>>>> tests for that compiler. If the timeouts persist, I can start just
>>>> disabling some tests for that compiler.
>>> This one is still timing out. I've disable the test for it with
>>> (CMAKE_COMPILER_FLAG MATCHES "Watcom").
>> You mean CMAKE_COMPILER_ID as in this commit, right?
>> That's fine.
> On closer inspection I figured it should be CMAKE_CXX_COMPILER_ID. I don't
> know if CMAKE_COMPILER_ID would work too...
You're right, it should be CMAKE_CXX_COMPILER_ID (or _C_). And do you
have the right logical sense of the if test? Do you want that simple
main for the Watcom compiler, or should it be a "NOT"? (I'm just
asking to double-check, I haven't dug in and read enough of your test
to fully appreciate the chunk shown in the gitweb diff view.)
>> Thank *you* -- your persistence has paid off.
>> I think tomorrow it will be passing enough to merge over to 'master' ...
> Great. Hopefully it will be useful to many.
I'm sure it will.
More information about the cmake-developers