| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0003354 | CMake | CMake | public | 2006-06-08 08:27 | 2006-10-04 15:22 | ||||
| Reporter | Jan Woetzel | ||||||||
| Assigned To | Bill Hoffman | ||||||||
| Priority | urgent | Severity | major | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0003354: 2.4.2 ADD_DEFINITIONS extra /D "" and quotes in MSVS 7.1 generator | ||||||||
| Description | ADD_DEFINTIONS should add a compiler flag to the command line, (not only defintions). On MSVS .net 2003 (7.1) genrator it adds extra quotes and prepends /D, e.g. ADD_DEFINTIONS( -foo ) results in /D "-foo" instead of -foo Linux Makefiles and NMake seem to work correctly. Jan. | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0004616) Torsten Martinsen (reporter) 2006-08-03 07:13 |
Actually, the problem is worse: All definitions added with ADD_DEFINITIONS() are inserted into the PreprocessorDefinitions value in the generated .vcproj file. I propose that 1) ADD_DEFINITIONS() is deprecated 2) A new command ADD_PREPROC_DEF (e.g.) with a syntax like that suggested in bug 3307, and which maps to the PreprocessorDefinitions value 3) A new command ADD_CFLAGS (e.g.) that does not do any mangling of the contents, and maps to the AdditionalOptions value in the .vcproj file. For Makefiles, both commands would map to the CXX_FLAGS or C_FLAGS variable. |
|
(0005023) Brad King (manager) 2006-09-23 17:00 |
Bug 0003664 is related to this. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |