MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003354CMakeCMakepublic2006-06-08 08:272006-10-04 15:22
ReporterJan Woetzel 
Assigned ToBill Hoffman 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0003354: 2.4.2 ADD_DEFINITIONS extra /D "" and quotes in MSVS 7.1 generator
DescriptionADD_DEFINTIONS
should add a compiler flag to the command line, (not only defintions).

On MSVS .net 2003 (7.1) genrator it adds extra quotes and prepends /D,
e.g.
ADD_DEFINTIONS( -foo ) results in
/D "-foo"
instead of
-foo

Linux Makefiles and NMake seem to work correctly.

Jan.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange

Notes
(0004616)
Torsten Martinsen   
2006-08-03 07:13   
Actually, the problem is worse: All definitions added with ADD_DEFINITIONS() are inserted into the PreprocessorDefinitions value in the generated .vcproj file.

I propose that
1) ADD_DEFINITIONS() is deprecated
2) A new command ADD_PREPROC_DEF (e.g.) with a syntax like that suggested in bug 3307, and which maps to the PreprocessorDefinitions value
3) A new command ADD_CFLAGS (e.g.) that does not do any mangling of the contents, and maps to the AdditionalOptions value in the .vcproj file.

For Makefiles, both commands would map to the CXX_FLAGS or C_FLAGS variable.
(0005023)
Brad King   
2006-09-23 17:00   
Bug 0003664 is related to this.