| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0015787 | CMake | CMake | public | 2015-10-13 08:31 | 2016-03-07 09:12 | ||||
| Reporter | James Crosby | ||||||||
| Assigned To | Brad King | ||||||||
| Priority | urgent | Severity | text | Reproducibility | N/A | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | |||||||||
| Target Version | CMake 3.4 | Fixed in Version | CMake 3.4 | ||||||
| Summary | 0015787: Please add note about <INCLUDES> change to 3.4 release notes | ||||||||
| Description | CMake 3.4 includes this change: https://github.com/Kitware/CMake/commit/c736de7b284ecc93bac48106e88417e0e6c92ad6 [^] which splits out <INCLUDES> from <FLAGS> in the CMAKE_C_COMPILE_OBJECT command. All toolchain descriptions which override this command need to be updated to work correctly with CMake 3.4, but this is not clearly documented anywhere, it seems like it should be a major item in the release notes! | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0039588) Brad King (manager) 2015-10-13 09:04 |
Yes, thanks for pointing this out. The change was made to internal interfaces: https://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/CMakeAddNewLanguage.txt;hb=v3.4.0-rc1#l7 [^] so projects that use them are responsible for porting. I will look at adding a release note to call attention to this. |
|
(0039593) Brad King (manager) 2015-10-13 11:49 |
I added a note here: Help: Add release note about compile rule placeholder changes https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=609a8921 [^] I've queued this for merge to 'release' for inclusion in 3.4.0-rc2. |
|
(0040615) Robert Maynard (manager) 2016-03-07 09:12 |
Closing resolved issues that have not been updated in more than 4 months. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2015-10-13 08:31 | James Crosby | New Issue | |
| 2015-10-13 09:04 | Brad King | Note Added: 0039588 | |
| 2015-10-13 09:04 | Brad King | Assigned To | => Brad King |
| 2015-10-13 09:04 | Brad King | Status | new => assigned |
| 2015-10-13 09:04 | Brad King | Target Version | => CMake 3.4 |
| 2015-10-13 11:49 | Brad King | Note Added: 0039593 | |
| 2015-10-13 11:49 | Brad King | Severity | major => text |
| 2015-10-13 11:49 | Brad King | Status | assigned => resolved |
| 2015-10-13 11:49 | Brad King | Resolution | open => fixed |
| 2015-10-13 11:49 | Brad King | Fixed in Version | => CMake 3.4 |
| 2016-03-07 09:12 | Robert Maynard | Note Added: 0040615 | |
| 2016-03-07 09:12 | Robert Maynard | Status | resolved => closed |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |