MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015787CMakeCMakepublic2015-10-13 08:312016-03-07 09:12
ReporterJames Crosby 
Assigned ToBrad King 
PriorityurgentSeveritytextReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionCMake 3.4Fixed in VersionCMake 3.4 
Summary0015787: Please add note about <INCLUDES> change to 3.4 release notes
DescriptionCMake 3.4 includes this change: https://github.com/Kitware/CMake/commit/c736de7b284ecc93bac48106e88417e0e6c92ad6 [^] which splits out <INCLUDES> from <FLAGS> in the CMAKE_C_COMPILE_OBJECT command.

All toolchain descriptions which override this command need to be updated to work correctly with CMake 3.4, but this is not clearly documented anywhere, it seems like it should be a major item in the release notes!
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-13 08:31James CrosbyNew Issue
2015-10-13 09:04Brad KingNote Added: 0039588
2015-10-13 09:04Brad KingAssigned To => Brad King
2015-10-13 09:04Brad KingStatusnew => assigned
2015-10-13 09:04Brad KingTarget Version => CMake 3.4
2015-10-13 11:49Brad KingNote Added: 0039593
2015-10-13 11:49Brad KingSeveritymajor => text
2015-10-13 11:49Brad KingStatusassigned => resolved
2015-10-13 11:49Brad KingResolutionopen => fixed
2015-10-13 11:49Brad KingFixed in Version => CMake 3.4
2016-03-07 09:12Robert MaynardNote Added: 0040615
2016-03-07 09:12Robert MaynardStatusresolved => closed

Notes
(0039588)
Brad King   
2015-10-13 09:04   
Yes, thanks for pointing this out.

The change was made to internal interfaces:

 https://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/CMakeAddNewLanguage.txt;hb=v3.4.0-rc1#l7 [^]

so projects that use them are responsible for porting. I will look at adding a release note to call attention to this.
(0039593)
Brad King   
2015-10-13 11:49   
I added a note here:

 Help: Add release note about compile rule placeholder changes
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=609a8921 [^]

I've queued this for merge to 'release' for inclusion in 3.4.0-rc2.
(0040615)
Robert Maynard   
2016-03-07 09:12   
Closing resolved issues that have not been updated in more than 4 months.