View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013234CMakeCMakepublic2012-05-17 10:472016-06-10 14:31
ReporterMathias Gaunard 
Assigned ToPeter Collingbourne 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionmoved 
Platformx86_64OSAnyOS Version3.2.0
Product VersionCMake 2.8.8 
Target VersionFixed in Version 
Summary0013234: Ninja: Add support for IMPLICIT_DEPENDS in add_custom_command
DescriptionIt would be nice if Ninja supported IMPLICIT_DEPENDS in add_custom_command like Makefile generators.

I personally use this feature when building precompiled headers. In the current state of affairs, I have to disable PCH generation and usage when using Ninja.
TagsNo tags attached.
Attached Files

 Relationships
related to 0015479closedKitware Robot Support depfiles from add_custom_command 

  Notes
(0029895)
Peter Kuemmel (developer)
2012-07-03 09:26

 IMPLICIT_DEPENDS is a documented feature, so it also have to work for ninja, and not supporting it is a bug.

Seems there is also no unit test, because all tests pass for ninja.
(0030022)
Peter Kuemmel (developer)
2012-07-10 11:05
edited on: 2012-07-10 11:14

 A test could be enabled in the BuildDepends test.

#-----------------------------------------------------------------------------
IF("${CMAKE_GENERATOR}" MATCHES "Make" OR "${CMAKE_GENERATOR}" MATCHES "Ninja")
  # Test the IMPLICIT_DEPENDS feature.
(0030024)
Mathias Gaunard (reporter)
2012-07-10 11:41

 The documentation states that IMPLICIT_DEPENDS is only supported by Makefile generators. Ninja is not a Makefile generator, which is why I originally marked this as a feature enhancement and not a bug.

"Note that the IMPLICIT_DEPENDS option is currently supported only for Makefile generators and will be ignored by other generators."
(0030468)
Peter Kuemmel (developer)
2012-08-13 08:45

 postpone
(0034728)
David Manura (reporter)
2013-12-05 13:47

 This issue causes problems with cotire precompiled header support on ninja. See
https://github.com/sakra/cotire/issues/21 [^]
(0040458)
davidshepherd7 (reporter)
2016-02-10 06:25

 This is (still) causing difficult-to-debug build failures when using cotire with ninja, any chance of a fix?
(0042050)
Kitware Robot (administrator)
2016-06-10 14:28

 Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

 Issue History
Date Modified Username Field Change
2012-05-17 10:47 Mathias Gaunard New Issue
2012-07-03 09:24 Peter Kuemmel Severity feature => major
2012-07-03 09:24 Peter Kuemmel Status new => confirmed
2012-07-03 09:24 Peter Kuemmel OS Linux => Any
2012-07-03 09:26 Peter Kuemmel Note Added: 0029895
2012-07-10 11:05 Peter Kuemmel Note Added: 0030022
2012-07-10 11:06 Peter Kuemmel Note Edited: 0030022
2012-07-10 11:14 Peter Kuemmel Note Edited: 0030022
2012-07-10 11:41 Mathias Gaunard Note Added: 0030024
2012-07-10 12:09 Peter Kuemmel Severity major => feature
2012-08-13 08:44 Peter Kuemmel Assigned To => Peter Collingbourne
2012-08-13 08:44 Peter Kuemmel Status confirmed => assigned
2012-08-13 08:45 Peter Kuemmel Note Added: 0030468
2012-08-13 08:45 Peter Kuemmel Status assigned => backlog
2013-12-05 13:47 David Manura Note Added: 0034728
2015-12-04 09:30 Brad King Relationship added related to 0015479
2016-02-10 06:25 davidshepherd7 Note Added: 0040458
2016-06-10 14:28 Kitware Robot Note Added: 0042050
2016-06-10 14:28 Kitware Robot Status backlog => resolved
2016-06-10 14:28 Kitware Robot Resolution open => moved
2016-06-10 14:31 Kitware Robot Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team