MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013234CMakeCMakepublic2012-05-17 10:472016-06-10 14:31
ReporterMathias Gaunard 
Assigned ToPeter Collingbourne 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionmoved 
Platformx86_64OSAnyOS Version3.2.0
Product VersionCMake 2.8.8 
Target VersionFixed in Version 
Summary0013234: Ninja: Add support for IMPLICIT_DEPENDS in add_custom_command
DescriptionIt would be nice if Ninja supported IMPLICIT_DEPENDS in add_custom_command like Makefile generators.

I personally use this feature when building precompiled headers. In the current state of affairs, I have to disable PCH generation and usage when using Ninja.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0015479closed Kitware Robot Support depfiles from add_custom_command 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-05-17 10:47Mathias GaunardNew Issue
2012-07-03 09:24Peter KuemmelSeverityfeature => major
2012-07-03 09:24Peter KuemmelStatusnew => confirmed
2012-07-03 09:24Peter KuemmelOSLinux => Any
2012-07-03 09:26Peter KuemmelNote Added: 0029895
2012-07-10 11:05Peter KuemmelNote Added: 0030022
2012-07-10 11:06Peter KuemmelNote Edited: 0030022bug_revision_view_page.php?bugnote_id=30022#r743
2012-07-10 11:14Peter KuemmelNote Edited: 0030022bug_revision_view_page.php?bugnote_id=30022#r744
2012-07-10 11:41Mathias GaunardNote Added: 0030024
2012-07-10 12:09Peter KuemmelSeveritymajor => feature
2012-08-13 08:44Peter KuemmelAssigned To => Peter Collingbourne
2012-08-13 08:44Peter KuemmelStatusconfirmed => assigned
2012-08-13 08:45Peter KuemmelNote Added: 0030468
2012-08-13 08:45Peter KuemmelStatusassigned => backlog
2013-12-05 13:47David ManuraNote Added: 0034728
2015-12-04 09:30Brad KingRelationship addedrelated to 0015479
2016-02-10 06:25davidshepherd7Note Added: 0040458
2016-06-10 14:28Kitware RobotNote Added: 0042050
2016-06-10 14:28Kitware RobotStatusbacklog => resolved
2016-06-10 14:28Kitware RobotResolutionopen => moved
2016-06-10 14:31Kitware RobotStatusresolved => closed

Notes
(0029895)
Peter Kuemmel   
2012-07-03 09:26   
IMPLICIT_DEPENDS is a documented feature, so it also have to work for ninja, and not supporting it is a bug.

Seems there is also no unit test, because all tests pass for ninja.
(0030022)
Peter Kuemmel   
2012-07-10 11:05   
(edited on: 2012-07-10 11:14)
A test could be enabled in the BuildDepends test.

#-----------------------------------------------------------------------------
IF("${CMAKE_GENERATOR}" MATCHES "Make" OR "${CMAKE_GENERATOR}" MATCHES "Ninja")
  # Test the IMPLICIT_DEPENDS feature.
(0030024)
Mathias Gaunard   
2012-07-10 11:41   
The documentation states that IMPLICIT_DEPENDS is only supported by Makefile generators. Ninja is not a Makefile generator, which is why I originally marked this as a feature enhancement and not a bug.

"Note that the IMPLICIT_DEPENDS option is currently supported only for Makefile generators and will be ignored by other generators."
(0030468)
Peter Kuemmel   
2012-08-13 08:45   
postpone
(0034728)
David Manura   
2013-12-05 13:47   
This issue causes problems with cotire precompiled header support on ninja. See
https://github.com/sakra/cotire/issues/21 [^]
(0040458)
davidshepherd7   
2016-02-10 06:25   
This is (still) causing difficult-to-debug build failures when using cotire with ninja, any chance of a fix?
(0042050)
Kitware Robot   
2016-06-10 14:28   
Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.