View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0013129

CMake

Modules

public

2012-04-13 16:04

2012-09-03 16:01

Reporter

Daniel Franke

Assigned To

Clinton Stimpson

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

no change required

Platform

OS Version

Product Version

CMake 2.8.7

Target Version

Fixed in Version

Summary

0013129: [patch] DeployQt4: wrong arguments to install_qt4_plugin

Description

The function DeployQt4.cmake(install_qt4_plugin) has this signature:
  function(install_qt4_plugin plugin executable copy installed_plugin_path_var)

but at line 144 of DeployQt4.cmake it is used as:
  install_qt4_plugin("${plugin}" "${plugins_dir}" "${executable}" 1 installed_plugin_path)

This leads to strange results on Windows (a directory 'installed_plugin_path' is created instead of ${plugins_dir}).

This trivial patch fixes my immediate problem, didn't test for side effects on other platforms:

Index: DeployQt4.cmake
===================================================================
--- DeployQt4.cmake (revision 275)
+++ DeployQt4.cmake (working copy)
@@ -141,7 +141,7 @@

         foreach(plugin ${qtplugins})
                 set(installed_plugin_path "")
- install_qt4_plugin("${plugin}" "${plugins_dir}" "${executable}" 1 installed_plugin_path)
+ install_qt4_plugin("${plugin}" "${executable}" 1 installed_plugin_path "${plugins_dir}")
                 list(APPEND libs ${installed_plugin_path})
         endforeach()

Tags

No tags attached.

Attached Files

Relationships

Notes
(0029151) Clinton Stimpson (developer) 2012-04-13 16:31	Can you try a 2.8.8 RC? There have been several fixes for DeployQt4 and a test added for it.

(0029152) Clinton Stimpson (developer) 2012-04-13 16:45	Its already been fixed.

(0030851) David Cole (manager) 2012-09-03 16:01	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2012-04-13 16:04	Daniel Franke	New Issue
2012-04-13 16:31	Clinton Stimpson	Note Added: 0029151
2012-04-13 16:44	Rolf Eike Beer	Assigned To	=> Clinton Stimpson
2012-04-13 16:44	Rolf Eike Beer	Status	new => assigned
2012-04-13 16:45	Clinton Stimpson	Note Added: 0029152
2012-04-13 16:45	Clinton Stimpson	Status	assigned => resolved
2012-04-13 16:45	Clinton Stimpson	Resolution	open => no change required
2012-09-03 16:01	David Cole	Note Added: 0030851
2012-09-03 16:01	David Cole	Status	resolved => closed