MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013129CMakeModulespublic2012-04-13 16:042012-09-03 16:01
ReporterDaniel Franke 
Assigned ToClinton Stimpson 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOSOS Version
Product VersionCMake 2.8.7 
Target VersionFixed in Version 
Summary0013129: [patch] DeployQt4: wrong arguments to install_qt4_plugin
DescriptionThe function DeployQt4.cmake(install_qt4_plugin) has this signature:
  function(install_qt4_plugin plugin executable copy installed_plugin_path_var)

but at line 144 of DeployQt4.cmake it is used as:
  install_qt4_plugin("${plugin}" "${plugins_dir}" "${executable}" 1 installed_plugin_path)

This leads to strange results on Windows (a directory 'installed_plugin_path' is created instead of ${plugins_dir}).

This trivial patch fixes my immediate problem, didn't test for side effects on other platforms:

Index: DeployQt4.cmake
===================================================================
--- DeployQt4.cmake (revision 275)
+++ DeployQt4.cmake (working copy)
@@ -141,7 +141,7 @@
 
         foreach(plugin ${qtplugins})
                 set(installed_plugin_path "")
- install_qt4_plugin("${plugin}" "${plugins_dir}" "${executable}" 1 installed_plugin_path)
+ install_qt4_plugin("${plugin}" "${executable}" 1 installed_plugin_path "${plugins_dir}")
                 list(APPEND libs ${installed_plugin_path})
         endforeach()
 
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-04-13 16:04Daniel FrankeNew Issue
2012-04-13 16:31Clinton StimpsonNote Added: 0029151
2012-04-13 16:44Rolf Eike BeerAssigned To => Clinton Stimpson
2012-04-13 16:44Rolf Eike BeerStatusnew => assigned
2012-04-13 16:45Clinton StimpsonNote Added: 0029152
2012-04-13 16:45Clinton StimpsonStatusassigned => resolved
2012-04-13 16:45Clinton StimpsonResolutionopen => no change required
2012-09-03 16:01David ColeNote Added: 0030851
2012-09-03 16:01David ColeStatusresolved => closed

Notes
(0029151)
Clinton Stimpson   
2012-04-13 16:31   
Can you try a 2.8.8 RC? There have been several fixes for DeployQt4 and a test added for it.
(0029152)
Clinton Stimpson   
2012-04-13 16:45   
Its already been fixed.
(0030851)
David Cole   
2012-09-03 16:01   
Closing resolved issues that have not been updated in more than 4 months.