View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0012923

CMake

CPack

public

2012-01-31 17:26

2012-09-03 16:02

Reporter

helsing72

Assigned To

Brad King

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Windows

OS Version

Windows XP

Product Version

CMake 2.8.7

Target Version

CMake 2.8.8

Fixed in Version

CMake 2.8.8

Summary

0012923: NSIS installer doesn't honor user permission

Description

When using the NSIS generator from CPack the file NSIS.template.in is used to generate a project.nsi file for NSIS to process. The file consists code in the NSIS scripting language. Among other functions there is an onInit function the initializes the installer. The function (tries to) recognise admin and power users but fails since NSIS scripting language relative includes the jump from the current command so +3 means "run the third command after this one", so a failed check for admin completely skips the check for a power user and goes directly to "done:"

Steps To Reproduce

Use the NSIS generator

Additional Information

attached patch fixes issue

Tags

No tags attached.

Attached Files

nsis-template.patch [^] (611 bytes) 2012-01-31 17:26 [Show Content] [Hide Content]

diff --git a/Modules/NSIS.template.in b/Modules/NSIS.template.in
index 6259a5b..819cc5c 100644
--- a/Modules/NSIS.template.in
+++ b/Modules/NSIS.template.in
@@ -922,12 +922,12 @@ Function .onInit
   Pop $0
   UserInfo::GetAccountType
   Pop $1
-  StrCmp $1 "Admin" 0 +3
+  StrCmp $1 "Admin" 0 +4
     SetShellVarContext all
     ;MessageBox MB_OK 'User "$0" is in the Admin group'
     StrCpy $SV_ALLUSERS "AllUsers"
     Goto done
-  StrCmp $1 "Power" 0 +3
+  StrCmp $1 "Power" 0 +4
     SetShellVarContext all
     ;MessageBox MB_OK 'User "$0" is in the Power Users group'
     StrCpy $SV_ALLUSERS "AllUsers"

Relationships

Notes
(0028435) Brad King (manager) 2012-02-01 08:13	It looks like this was introduced here: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b1b052fd#patch2 [^] where lines were added without updating the jump length.

(0028436) Brad King (manager) 2012-02-01 08:23	Applied patch, thanks! http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c4a0bcea [^]

(0030879) David Cole (manager) 2012-09-03 16:02	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2012-01-31 17:26	helsing72	New Issue
2012-01-31 17:26	helsing72	File Added: nsis-template.patch
2012-02-01 08:13	Brad King	Note Added: 0028435
2012-02-01 08:23	Brad King	Note Added: 0028436
2012-02-01 08:23	Brad King	Status	new => resolved
2012-02-01 08:23	Brad King	Resolution	open => fixed
2012-02-01 08:23	Brad King	Assigned To	=> Brad King
2012-04-19 15:46	David Cole	Fixed in Version	=> CMake 2.8.8
2012-04-19 15:46	David Cole	Target Version	=> CMake 2.8.8
2012-09-03 16:02	David Cole	Note Added: 0030879
2012-09-03 16:02	David Cole	Status	resolved => closed