MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012923CMakeCPackpublic2012-01-31 17:262012-09-03 16:02
Reporterhelsing72 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSWindowsOS VersionWindows XP
Product VersionCMake 2.8.7 
Target VersionCMake 2.8.8Fixed in VersionCMake 2.8.8 
Summary0012923: NSIS installer doesn't honor user permission
DescriptionWhen using the NSIS generator from CPack the file NSIS.template.in is used to generate a project.nsi file for NSIS to process. The file consists code in the NSIS scripting language. Among other functions there is an onInit function the initializes the installer. The function (tries to) recognise admin and power users but fails since NSIS scripting language relative includes the jump from the current command so +3 means "run the third command after this one", so a failed check for admin completely skips the check for a power user and goes directly to "done:"
Steps To ReproduceUse the NSIS generator
Additional Informationattached patch fixes issue
TagsNo tags attached.
Relationships
Attached Filespatch nsis-template.patch (611) 2012-01-31 17:26
https://public.kitware.com/Bug/file/4200/nsis-template.patch
Issue History
Date ModifiedUsernameFieldChange
2012-01-31 17:26helsing72New Issue
2012-01-31 17:26helsing72File Added: nsis-template.patch
2012-02-01 08:13Brad KingNote Added: 0028435
2012-02-01 08:23Brad KingNote Added: 0028436
2012-02-01 08:23Brad KingStatusnew => resolved
2012-02-01 08:23Brad KingResolutionopen => fixed
2012-02-01 08:23Brad KingAssigned To => Brad King
2012-04-19 15:46David ColeFixed in Version => CMake 2.8.8
2012-04-19 15:46David ColeTarget Version => CMake 2.8.8
2012-09-03 16:02David ColeNote Added: 0030879
2012-09-03 16:02David ColeStatusresolved => closed

Notes
(0028435)
Brad King   
2012-02-01 08:13   
It looks like this was introduced here:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b1b052fd#patch2 [^]

where lines were added without updating the jump length.
(0028436)
Brad King   
2012-02-01 08:23   
Applied patch, thanks!

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c4a0bcea [^]
(0030879)
David Cole   
2012-09-03 16:02   
Closing resolved issues that have not been updated in more than 4 months.