[CMake] patch proposal for PythonInterp
Rolf Eike Beer
eike at sf-mail.de
Fri Apr 12 12:45:44 EDT 2013
Brad King wrote:
> On 04/11/2013 04:05 PM, Yngve Inntjore Levinsen wrote:
> > On 11. april 2013 21:31, Matthew Woehlke wrote:
> >>> Where do I submit the merge request? Open a bug report?
> >>
> >> I would recommend following the 'share a topic' instructions at
> >> http://www.cmake.org/Wiki/CMake/Git/Develop.
> >
> > Thanks for the link, but I feel this is more for module keepers, and
>
> It is. Individual one-off contributions do not need to go that path.
>
> > this is not my module. I think Eike is responsible for this module (at
> > least he has the last commits), so I would prefer if he or someone else
> > with commit access could push it to the stage repository for review (if
> > they agree with the patch).
>
> Eike, since you invited Yngve to submit this patch in this thread,
> please take a look.
>
> One cosmetic comment I have from a quick glance is that the macros
> the patch adds should be named with a _PythonInterp_ prefix so that
> they do not collide with other modules that may do something similar.
Yes, I will take a look. So far it looks not too bad. Yngve, please make the
changes Brad requested and squash both patches together so I need to review
only those changes that you really intend to do.
I've only touched the Python modules because I was upset by all the crap
having been done to it by downstreams. I don't really care for Python at all.
So I would love to see if you or anyone else steps up and takes ownership of
those. Of course I'll be still around and answer questions, but I would really
prefer if someone would have a regular look on those things who actually as a
clue or an interst of Python (I have neither).
Eike
--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://www.cmake.org/pipermail/cmake/attachments/20130412/3590c949/attachment.pgp>
More information about the CMake
mailing list