[CMake] patch proposal for PythonInterp

Brad King brad.king at kitware.com
Fri Apr 12 08:22:09 EDT 2013


On 04/11/2013 04:05 PM, Yngve Inntjore Levinsen wrote:
> On 11. april 2013 21:31, Matthew Woehlke wrote:
>>> Where do I submit the merge request? Open a bug report?
>>
>> I would recommend following the 'share a topic' instructions at
>> http://www.cmake.org/Wiki/CMake/Git/Develop. 
> 
> Thanks for the link, but I feel this is more for module keepers, and

It is.  Individual one-off contributions do not need to go that path.

> this is not my module. I think Eike is responsible for this module (at
> least he has the last commits), so I would prefer if he or someone else
> with commit access could push it to the stage repository for review (if
> they agree with the patch).

Eike, since you invited Yngve to submit this patch in this thread,
please take a look.

One cosmetic comment I have from a quick glance is that the macros
the patch adds should be named with a _PythonInterp_ prefix so that
they do not collide with other modules that may do something similar.

Thanks,
-Brad


More information about the CMake mailing list