[CMake] Bug#553151: CMake 2.8.0 RC 4 ready for testing!
Mathieu Malaterre
mathieu.malaterre at gmail.com
Thu Oct 29 12:30:11 EDT 2009
On Thu, Oct 29, 2009 at 4:44 PM, Bill Hoffman <bill.hoffman at kitware.com> wrote:
> Modestas Vainius wrote:
>>
>> Hello,
>>
>> On ketvirtadienis 29 Spalis 2009 14:50:14 Mathieu Malaterre wrote:
>>>
>>> On Thu, Oct 29, 2009 at 1:35 PM, Bill Hoffman <bill.hoffman at kitware.com>
>>
>> wrote:
>>>>
>>>> Mathieu Malaterre wrote:
>>>>>
>>>>> # ok we found jni.h, now derive other location from it:
>>>>> get_filename_component(jni_path ${JAVA_INCLUDE_PATH} PATH)
>>>>>
>>>>> FIND_PATH(JAVA_INCLUDE_PATH2 jni_md.h
>>>>> ${jni_path}
>>>>> ${jni_path}/win32
>>>>> ${jni_path}/linux
>>>>> ${jni_path}/freebsd
>>>>> )
>>>>>
>>>>> FIND_PATH(JAVA_AWT_INCLUDE_PATH jawt.h
>>>>> ${jni_path}
>>>>> )
>>>>
>>>> This looks reasonable. Is there a case where this will not work?
>>>
>>> I would be tempted to say that this is safe in all cases. Any comments
>>> Modestas ?
>>
>> Looks fine and logical for me as well.
>>
> Mathiueu can you create a patch for this and make sure it works for you, and
> then attach it to the bug?
Done:
http://cmake.org/Bug/view.php?id=9793
Bug report include the test I used. Unfortunately find_package caches
results, so one need to manually remove cmakecache.txt file before
re-running this.
Cheers
--
Mathieu
More information about the CMake
mailing list