View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0009793

CMake

public

2009-10-29 12:27

2009-10-29 13:48

Reporter

Mathieu Malaterre

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0009793: FindJNI.cmake confused in multiple installation.

Description

FindJNI.cmake would pick a jni.h file from one java installation and a jni_md.h from another installation.

Attached patch solved situation.

Additional Information

Testing consisted in running:

http://gdcm.svn.sourceforge.net/svnroot/gdcm/Sandbox/CMakeBug/8/CMakeLists.txt [^]

project(testjni)
# Check that JAVA_HOME setting works with find_package(JNI)

cmake_minimum_required(VERSION 2.8)

macro(CHECK_JNI ref)
  message("working on ${ref}")
  set(ENV{JAVA_HOME} ${ref})
  find_package(JNI)
  message(${JNI_INCLUDE_DIRS})
  message(${JNI_LIBRARIES})

  foreach(include ${JNI_INCLUDE_DIRS})
    string(REGEX MATCH ${ref} out ${include})
    if(NOT out)
      message(FATAL_ERROR "problem with ${include} should contains ${ref}")
    endif(NOT out)
  endforeach(include)
endmacro(CHECK_JNI)

# locate jni.h
  # /usr/lib/gcc-snapshot/lib/gcc/x86_64-linux-gnu/4.5.0/include/jni.h
  # /usr/lib/gcc-snapshot/lib/jvm/java-1.5.0-gcj-4.5-snap/include/jni.h
  # /usr/lib/jvm/java-1.5.0-gcj-4.3-1.5.0.0/include/jni.h
  # /usr/lib/jvm/java-1.5.0-gcj-4.4/include/jni.h
  # /usr/lib/jvm/java-6-openjdk/include/jni.h
  # /usr/lib/jvm/java-6-sun-1.6.0.12/include/jni.h

set(java_loc
  #/usr/lib/gcc-snapshot/lib/gcc/x86_64-linux-gnu/4.5.0/
  #/usr/lib/gcc-snapshot/lib/jvm/java-1.5.0-gcj-4.5-snap/ # ok
  #/usr/lib/jvm/java-1.5.0-gcj-4.3-1.5.0.0/
  #/usr/lib/jvm/java-1.5.0-gcj-4.4/
  #/usr/lib/jvm/java-6-openjdk/
  /usr/lib/jvm/java-6-sun-1.6.0.12/
  )

foreach(ref ${java_loc})
  CHECK_JNI(${ref})
endforeach(ref)

Tags

No tags attached.

Attached Files

jni_include_path.patch [^] (644 bytes) 2009-10-29 12:27 [Show Content] [Hide Content]

Index: Modules/FindJNI.cmake
===================================================================
RCS file: /cvsroot/CMake/CMake/Modules/FindJNI.cmake,v
retrieving revision 1.45
diff -u -r1.45 FindJNI.cmake
--- Modules/FindJNI.cmake	22 Oct 2009 10:57:00 -0000	1.45
+++ Modules/FindJNI.cmake	29 Oct 2009 16:25:07 -0000
@@ -195,14 +195,13 @@
 )
 
 FIND_PATH(JAVA_INCLUDE_PATH2 jni_md.h 
-  ${JAVA_AWT_INCLUDE_DIRECTORIES}
+  ${JAVA_INCLUDE_PATH}
   ${JAVA_INCLUDE_PATH}/win32
   ${JAVA_INCLUDE_PATH}/linux
   ${JAVA_INCLUDE_PATH}/freebsd
 )
 
 FIND_PATH(JAVA_AWT_INCLUDE_PATH jawt.h
-  ${JAVA_AWT_INCLUDE_DIRECTORIES}
   ${JAVA_INCLUDE_PATH}
 )

Relationships

Notes
(0018278) Bill Hoffman (manager) 2009-10-29 13:48	$ cvs commit -m "Fix for bug 0009793 try to make sure jni.h matches jni_md.h " FindJNI.cmake Committer: Bill Hoffman <bill.hoffman@kitware.com> /cvsroot/CMake/CMake/Modules/FindJNI.cmake,v <-- FindJNI.cmake new revision: 1.46; previous revision: 1.45

Issue History
Date Modified	Username	Field	Change
2009-10-29 12:27	Mathieu Malaterre	New Issue
2009-10-29 12:27	Mathieu Malaterre	File Added: jni_include_path.patch
2009-10-29 13:48	Bill Hoffman	Note Added: 0018278
2009-10-29 13:48	Bill Hoffman	Status	new => closed
2009-10-29 13:48	Bill Hoffman	Resolution	open => fixed