[cmake-developers] FastBuild Generator
Brad King
brad.king at kitware.com
Thu Oct 6 11:32:24 EDT 2016
On 10/06/2016 08:32 AM, Charles Huet wrote:
> Do you think it is time to start the review, or should it wait
> until I have 100% of the tests passing ?
Thanks for the update. Generally my reviews for new features
mostly look at documentation, tests, style, etc. rather than
at implementation details (which can easily be fixed/changed
later). Therefore final review and integration should not start
until everything is working.
However, I'm happy to take quick glances at progress once in
a while. Here are some comments from the current version:
* Please use Utilities/Scripts/clang-format.bash for
code style. This is easy to apply automatically later
so don't worry about it too much.
* For final integration I'd like the commits to be squashed
and arranged in an organized way. This is hard to do until
you have everything working though.
* Please update the license notices to use the new style that
we switched to in `master`. Both C++ and .cmake notices
changed.
Thanks,
-Brad
More information about the cmake-developers
mailing list