[cmake-developers] [CMake 0016030]: CMAKE_ASM_NASM_COMPILE_OBJECT lacks <INCLUDES>

Gregor Jasny gjasny at googlemail.com
Fri Mar 25 18:27:39 EDT 2016


On 25/03/16 19:28, Brad King wrote:
> On 03/25/2016 01:46 PM, Gregor Jasny via cmake-developers wrote:
>> Does anyone see a reason to *not* prepend all <FLAGS> with a <INCLUDES>?
> 
> I'm not particularly familiar with the ASM tooling landscape but
> that prepend step is exactly what was done for all other languages
> in commit v3.4.0-rc1~342^2 (Factor an <INCLUDES> placeholder out
> of <FLAGS> in rule variables, 2015-07-13):
> 
>   Factor an <INCLUDES> placeholder out of <FLAGS> in rule variables
>   https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c736de7b
> 
> Since prior to that change the -I flags were included in <FLAGS>
> I think leaving ASM changes out of the commit was an oversight.

I pushed a first commit to asm-includes topic but did not merge to next,
yet. Looking at your quoted patch I wonder if <DEFINES> is missing as well?

Thanks,
Gregor



More information about the cmake-developers mailing list