[cmake-developers] Ninja and add_subdirectory EXCLUDE_FROM_ALL

[Charles Huet]

ConvertToNinjaPath sadly makes the path relative to the binary dir, not the
source dir.

I added a utility function 'ConvertToNinjaFolderRule' that does the same
thing as ConvertToNinjaPath, but makes relative to the source dir, and adds
the '/all' suffix.

I also made the lines less than 79 chars.

Best


Le jeu. 17 mars 2016 à 15:53, Brad King <brad.king at kitware.com> a écrit :

> On 03/16/2016 12:13 PM, Charles Huet wrote:
> >> On 03/16/2016 04:59 AM, Charles Huet wrote:
> >>> If you have other ideas on how to improve this patch, I'll be happy to
> >>> implement them.
>
> All paths that are given to WritePhonyBuild in the outputs and depends
> options should be sent through ConvertToNinjaPath.  This makes paths
> relative and formats slashes for Windows.  This should avoid the need
> to do string manipulation on the paths (e.g. substr) too.  Just be sure
> to append the "/all" before calling the conversion method.
>
> Also please keep source lines to 79 characters or less.
>
> Thanks,
> -Brad
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160317/9d1f6a6c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Added-a-target-for-each-EXCLUDED_FROM_ALL-folder-tha.patch
Type: text/x-patch
Size: 5426 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160317/9d1f6a6c/attachment.bin>