[cmake-developers] Ninja and add_subdirectory EXCLUDE_FROM_ALL

Brad King brad.king at kitware.com
Thu Mar 17 10:53:20 EDT 2016


On 03/16/2016 12:13 PM, Charles Huet wrote:
>> On 03/16/2016 04:59 AM, Charles Huet wrote:
>>> If you have other ideas on how to improve this patch, I'll be happy to
>>> implement them.

All paths that are given to WritePhonyBuild in the outputs and depends
options should be sent through ConvertToNinjaPath.  This makes paths
relative and formats slashes for Windows.  This should avoid the need
to do string manipulation on the paths (e.g. substr) too.  Just be sure
to append the "/all" before calling the conversion method.

Also please keep source lines to 79 characters or less.

Thanks,
-Brad



More information about the cmake-developers mailing list