[cmake-developers] patch for module GetPrerequisites

Brad King brad.king at kitware.com
Mon Mar 7 13:07:00 EST 2016


On 03/04/2016 12:17 PM, Benjamin Ballet wrote:
> The fail occurs during verify_app in the function gp_resolved_file_type
> from module GetPrerequisites. This function test if two paths are equal
> without translating them to there canonical form before.
[snip]
>        get_filename_component(original_path "${original_lower}" PATH)
>        get_filename_component(path "${lower}" PATH)
> +      get_filename_component(original_path "${original_path}" REALPATH)
> +      get_filename_component(path "${path}" REALPATH)

This is operating on a string(TOLOWER)-converted path already.
On case-sensitive filesystems it does not make sense to call
REALPATH for these.  The code is doing string manipulation of
the paths at this point.

Please explain the case you're hitting in more detail.  How
does one end up with a non-canonical path in the first place?

Thanks,
-Brad



More information about the cmake-developers mailing list