[cmake-developers] [PATCH] add debug glew to FindGLEW

[Farbos a]

Brad,

Here is the patch fixed.

Thanks,


2016-06-20 16:17 GMT+02:00 Brad King <brad.king at kitware.com>:
> On 06/20/2016 07:55 AM, Farbos a wrote:
>> I added the Glew debug library to the FindGLEW.cmake, here is the patch.
>
> Good start.  Here are some comments:
>
> * For compatibility with scripts that set GLEW_LIBRARY we need to
>   honor the old name if it is set.  See FindZLIB for an example.
>   (Near the "Allow ZLIB_LIBRARY to be set manually" comment.)
>
> * The imported target needs to have each configuration added only
>   if it exists.  See FindZLIB for an example.  IMPORTED_CONFIGURATIONS
>   needs to list the available configurations.
>
> Thanks,
> -Brad
>



-- 
Arnaud FARBOS
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-add-debug-glew-to-FindGLEW.patch
Type: application/octet-stream
Size: 2544 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160620/f37e7485/attachment.obj>