[cmake-developers] [PATCH] add debug glew to FindGLEW

Brad King brad.king at kitware.com
Mon Jun 20 10:17:45 EDT 2016


On 06/20/2016 07:55 AM, Farbos a wrote:
> I added the Glew debug library to the FindGLEW.cmake, here is the patch.

Good start.  Here are some comments:

* For compatibility with scripts that set GLEW_LIBRARY we need to
  honor the old name if it is set.  See FindZLIB for an example.
  (Near the "Allow ZLIB_LIBRARY to be set manually" comment.)

* The imported target needs to have each configuration added only
  if it exists.  See FindZLIB for an example.  IMPORTED_CONFIGURATIONS
  needs to list the available configurations.

Thanks,
-Brad



More information about the cmake-developers mailing list