[cmake-developers] [PATCH v2] Improve encoding handling on Windows

Brad King brad.king at kitware.com
Tue Jul 5 13:04:03 EDT 2016


On 07/03/2016 09:22 AM, Dāvis Mosāns wrote:
> Huge thanks for review! Will fix mentioned issues in next version of patch.
> Also I'll implement this solution with std::streambuf as it's much better way
> and it's actually not that much work I thought it would be.

Yes, thanks Mike!

Dāvis, in the next round please split out refactoring changes like
converting clients to the alternative GetEnv signature into preceding
commits.  That will simplify review and allow many hunks to be
integrated even if other changes need more revisions.

Thanks,
-Brad



More information about the cmake-developers mailing list