[cmake-developers] [PATCH v2] Improve encoding handling on Windows

[Dāvis Mosāns]

2016-07-03 13:04 GMT+03:00 Mike Gelfand <mikedld at mikedld.com>:

> For std::c(in|out|err) vs. std::wc(in|out|err), here's an implementation
> of std::streambuf which we currently use in our projects:
> http://stackoverflow.com/a/21728856/583456. You could either try using
> it as is or use it as a base for your own implementation; in any case,
> it's better than forcing people to use one or another stream based on
> current OS.
>
> Not sure what currently accepted CMake coding style dictates, but
> several variables could be made const (e.g. `envVarSet` in
> `cmExtraEclipseCDT4Generator::AddEnvVar`).
>
> Apart from notes above and a few indentation issues which may be fixed
> during merge, below are some more observations.
>
>
Huge thanks for review! Will fix mentioned issues in next version of patch.
Also I'll implement this solution with std::streambuf as it's much better
way
and it's actually not that much work I thought it would be.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160703/aca5d32d/attachment.html>