[cmake-developers] [PATCH] Improve encoding handling on Windows

[Mike Gelfand]

On 07/01/2016 05:12 PM, Ben Boeckel wrote:
> On Fri, Jul 01, 2016 at 16:44:32 +0300, Dāvis Mosāns wrote:
>> 2. change GetEnv to return std::unique_ptr<std:string> which will be
>>   automatically deleted once out of scope and we still can check if there
>>   wasn't such env if it's empty.
> Hrm. I'd rather use std::optional than relying on implicit nullptr
> semantics.

Since you already have "bool SystemTools::GetEnv(const char* key,
std::string& result)", another option would be to use it everywhere and
maybe introduce something like "bool SystemTools::HasEnv(const char*
key)" for those several cases where you only need to check the existence.

Regards,
Mike