[cmake-developers] [PATCH] Improve encoding handling on Windows

Brad King brad.king at kitware.com
Fri Jul 1 10:38:38 EDT 2016


On 07/01/2016 10:16 AM, Daniel Pfeifer wrote:
>> Hrm. I'd rather use std::optional than relying on implicit nullptr
>> semantics.
> 
> +1.
> 
> This class here should be renamed to cmOptional and moved to its own
> file, so it may be reused:
> http://public.kitware.com/gitweb?p=stage/cmake.git;a=blob;f=Source/cmArchiveWrite.h;h=f847d09b74922e800293e70c3171accb500c083c;hb=refs/heads/master#l22

The GetEnv method in question is in KWSys which has clients besides
CMake.  I'd like to avoid adding an Optional class to it or using
C++11 in it.  Please see my response in another part of this thread.

-Brad



More information about the cmake-developers mailing list