[cmake-developers] Review request: extract-cmMessenger branch

Stephen Kelly steveire at gmail.com
Sat Jan 30 07:39:55 EST 2016


Michael Scott wrote:

>> * Make it possible to make add first-class handling of messages about
>> missing packages (for example) to cmake-gui by making methods on
>> cmMessenger virtual and subclassing
>
> This sounds like a good idea and makes a lot of sense.
> 
> While working on the message functionality previously it felt like it
> was tacked on as an afterthought, I think moving in this direction will
> help lead to message functionality that can be expanded and improved
> upon much more easily in the future.

Yes. Did you have a close look at the commits? I'm not really sure they are 
correct, and I wonder if you have any thoughts on the first one which 
discusses interface?

> This may be a stupid question, but I previously wondered why CMake
> doesn't use (or at least obviously use) a standard logging library,
> similar to log4j, for some of this stuff?

I don't know the answer to this.

Thanks,

Steve.




More information about the cmake-developers mailing list