[cmake-developers] [PATCH] Add FindLTTngUST module to find LTTng-UST library

Philippe Proulx eeppeliteloop at gmail.com
Fri Feb 26 20:18:22 EST 2016


Thanks.

I submitted a v2, but I'm still wondering: do I need to extract the
documentation somehow, to put it in Help/module, or is it
automatically extracted once it's merged?
Philippe Proulx


On Fri, Feb 26, 2016 at 10:42 AM, Brad King <brad.king at kitware.com> wrote:
> On 02/19/2016 08:09 PM, Philippe Proulx wrote:
>> Signed-off-by: Philippe Proulx <eeppeliteloop at gmail.com>
>> ---
>>  Modules/FindLTTngUST.cmake | 88 ++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 88 insertions(+)
>>  create mode 100644 Modules/FindLTTngUST.cmake
>
> Thanks for working on this.
>
> Please look at adding imported targets as described here:
>
>   https://cmake.org/cmake/help/v3.5/manual/cmake-developer.7.html#find-modules
>
> See the FindPNG module for an example.  Also please add a test
> case.  Grep in the Tests directory for "FindPNG" for an example.
>
> Also please udpate Tests/CMakeOnly/AllFindModules/CMakeLists.txt
> at the bottom to check that the version string is available for
> this package.
>
> Thanks,
> -Brad
>


More information about the cmake-developers mailing list