[cmake-developers] [PATCH] Add FindLTTngUST module to find LTTng-UST library

Brad King brad.king at kitware.com
Fri Feb 26 10:42:25 EST 2016


On 02/19/2016 08:09 PM, Philippe Proulx wrote:
> Signed-off-by: Philippe Proulx <eeppeliteloop at gmail.com>
> ---
>  Modules/FindLTTngUST.cmake | 88 ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 88 insertions(+)
>  create mode 100644 Modules/FindLTTngUST.cmake

Thanks for working on this.

Please look at adding imported targets as described here:

  https://cmake.org/cmake/help/v3.5/manual/cmake-developer.7.html#find-modules

See the FindPNG module for an example.  Also please add a test
case.  Grep in the Tests directory for "FindPNG" for an example.

Also please udpate Tests/CMakeOnly/AllFindModules/CMakeLists.txt
at the bottom to check that the version string is available for
this package.

Thanks,
-Brad



More information about the cmake-developers mailing list