[cmake-developers] Add native options to the clean step of 'cmake --build .. --clean-first'

[Yves Frederix]

Hi all,

In PR https://gitlab.kitware.com/cmake/cmake/merge_requests/329 I am
suggesting to not only pass the additional/native build options to the
actual build step, but also to the 'clean' step in case of a call like
`cmake --build ... --clean-first`. The change is simple enough, but
there is the risk that a 'make clean' does not accept the additional
build options that for a normal build are ok, which could cause a
build to fail. Hence, I would like to check with the devs on this list
to judge the actual risk of this PR.

Brad suggested to check the git logs to see if I could find something
there. I tracked things down to d35651fb in which the additional build
options were added.to the Build() function. It seems that already from
the beginning, the additional options were only passed to the build
step itself and not to the clean step. Whether there was a reason for
this is unclear from the logs.

My question now is whether somebody remembers if there indeed was a
particular reason to leave out the additional options from the 'make
clean' call? And if not, could you come up with a real example in
which case the proposed change would cause a build failure? I have
tried, but wasn't able to come up with anything, although I must admit
that my view is limited as I do not have much experience with non-VS
generators.

Thanks.

Yves