[cmake-developers] cmake -E capabilities [attempt 2]
Brad King
brad.king at kitware.com
Wed Aug 3 09:52:41 EDT 2016
On 08/02/2016 04:48 PM, Stephen Kelly wrote:
> The NewFactory methods in your patch don't return a new'd object, but
> instead return static locals. The regular generators NewFactory methods
> don't work that way, so you're introducing a pattern which is different to
> what already exists and the commit message doesn't say why.
I've revised Tobias's commits to rename NewFactory to GetFactory and
explain some rationale in the commit message:
Refactor extra generator registration to use factories
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a354f60c
Report more information about extra generators in generator factories
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cd52a225
I don't think the granularity is too low for these particular changes.
The commit only looks large because it essentially updates the syntax
used to express a table of information. Perhaps this syntax update and
the main logic updates could be separated but IMO it's good enough.
-Brad
More information about the cmake-developers
mailing list