[cmake-developers] [Patch 3/5] Improved WIX support

[Nils Gladitz]

On 07/20/2016 03:58 PM, Stuermer, Michael SP/HZA-ZSEP wrote:

> Using the patchfile support I managed to implement the service installation issue I had, so the unnecessary features from the last patch are removed now.
>
> I tested all patches separately and hope they work now.
>
> looking forward for feedback,
>
> best regrads,
> Michael

Patch 3 looks OK but I think I would prefer using WiX over CPack 
nomenclature in the variables you introduce.

e.g.

     CPACK_WIX_ROOT_FEATURE_TITLE and
     CPACK_WIX_ROOT_FEATURE_DESCRIPTION

over

     CPACK_WIX_ROOT_COMPONENT_DISPLAY_NAME and
     CPACK_WIX_ROOT_COMPONENT_DESCRIPTION

given that CPack has no concept of a root component.

Would you agree?

Nils