[cmake-developers] Automoc same source - More thoughts

Sebastian Holtermann seblist at xwmw.org
Sat Apr 16 07:41:47 EDT 2016


Am 14.04.2016 um 23:06 schrieb Sebastian Holtermann:
>
>> These two hunks look like error checks added to the existing logic.
>> Please split these out into preceding commits with their own messages
>> explaining the new errors.  Please also include a
>>
>>   Help/release/dev/automoc-diagnostics.rst
>>
>> file with a release note explaining the new diagnostics.
>>
>
> Wow, this turned into a git learning session for me.
> Git is as awesome as it is hard.
>
> I've split the patch into three as suggested.
>

Please do not commit.

After checking a greater picture and
https://cmake.org/Bug/view.php?id=16068
I found that an adapted more generic test
would help with qrc and ui file generation, too.
I'm going to start a new thread next week.

-Sebastian



More information about the cmake-developers mailing list