[cmake-developers] Automoc same source - More thoughts

Sebastian Holtermann seblist at xwmw.org
Thu Apr 14 17:06:30 EDT 2016


> These two hunks look like error checks added to the existing logic.
> Please split these out into preceding commits with their own messages
> explaining the new errors.  Please also include a
>
>   Help/release/dev/automoc-diagnostics.rst
>
> file with a release note explaining the new diagnostics.
>

Wow, this turned into a git learning session for me.
Git is as awesome as it is hard.

I've split the patch into three as suggested.

-Sebastian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmake_automoc_name_collision_check-2016-04-14-1.patch
Type: text/x-patch
Size: 3946 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160414/bd389296/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmake_automoc_include_parent_check-2016-04-14-1.patch
Type: text/x-patch
Size: 2251 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160414/bd389296/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmake_automoc_moc_directories-2016-04-14-1.patch
Type: text/x-patch
Size: 5261 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20160414/bd389296/attachment-0002.bin>


More information about the cmake-developers mailing list