[cmake-developers] [PATCH] ExternalProject: Allow TLS_VERIFY for git clones

Ben Boeckel ben.boeckel at kitware.com
Fri Apr 1 10:13:53 EDT 2016


On Fri, Apr 01, 2016 at 10:58:50 +0100, Samir Benmendil wrote:
> +# set git_options
> +if(NOT tls_verify)
> +  set(git_options -c http.sslVerify=false)
> +endif()

Looks good overall, but could this be turned into a pattern like:

    set(git_options)
    if (NOT tls_verify)
      list(APPEND git_options
        -c http.sslVerify=false)
    endif ()

to help out future options which might make sense?

Thanks,

--Ben


More information about the cmake-developers mailing list