[cmake-developers] CPack/NSIS is broken after extended length paths fix
clinton at elemtech.com
clinton at elemtech.com
Fri Sep 18 11:31:03 EDT 2015
----- On Sep 18, 2015, at 6:07 AM, Dmitry Kochkin <cooch at mail.ru> wrote:
> Hi Clinton,
> I was looking into an issue that we have in CMake on Windows with extended paths
> and later on realized that you've fixed it.
> However I've realized that you fixed it only in cmSystemTools, which fixes e.g.
> INSTALL, but does not fix cpack.
Yes, I was fixing the 'install' to work with paths > 260 characters, and was using the cpack archive generator at the time.
With the path to the build tree, plus the "_CPackPackage/....", some of these paths can become quite long.
> Actually it's even worse because in current master HEAD I can see that INST_DIR
> is empty in generated project:
> !define INST_DIR ""
> (not sure if that's caused by your change)
Interesting... Do you know why this happens? How is this problem related to extended paths (with the \\?\ prefix)? Do you have an example to demonstrate this problem?
> I've figured out that NSIS was not going to fix this (see
> http://sourceforge.net/p/nsis/feature-requests/241/ )
Maybe they'll accept a patch to fix it there? Was there any effort to fix it there?
> I've made a small patch to NSIS generator and template to put infamous \\?\
> there.
> I can send directly to you as I guess you know more about these parts of code.
You can send your patch to this mailing list for review.
Clint
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150918/d6a52874/attachment-0001.html>
More information about the cmake-developers
mailing list